Change captions to use <figure> and <figcaption> #1321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
<figcaption>
will result in a new<figcaption>
being created, rather than a new paragraph outside of the<figure>
. The same issue already exists in v4 - editing a caption and hitting return will add another<p class="caption">
instead of breaking out of the containing div. On save, they both get concatenated into a single caption though.<figure>
in TinyMCE, but not when the shortcode is rendered. That’ll need a separate PR to framework to update the shortcode templateextended_valid_elements
should be made here or in framework<figure>
instead of a<div>
like it currently is. I kept it as a<div>
, but it might be better to just always use a<figure>
so it’s a predictable element. Apparently a figure without a figcaption is fine.